Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all identity-related code from celo-blockchain #572

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Nov 6, 2019

Description

With the move to make the reveal off-chain, we can remove all identity related code from celo-blockchain

Tested

  • compiles

Related issues

Backwards compatibility

  • Not compatible with the contract version of Attestations that still reveals on-chain

@nambrot nambrot requested a review from asaj as a code owner November 6, 2019 03:56
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@asaj asaj assigned nambrot and unassigned asaj Nov 6, 2019
@asaj
Copy link
Contributor

asaj commented Nov 6, 2019

Is there a corresponding PR that removes this code from Attestations.sol?

@nambrot
Copy link
Contributor Author

nambrot commented Nov 6, 2019

Yes! celo-org/celo-monorepo#1578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developers should not be able to reference identity related code in celo-blockchain
4 participants